From 4aa68f9317957c043f0deb8950d3fc11752d25f2 Mon Sep 17 00:00:00 2001
From: Xuefer <xuefer@gmail.com>
Date: Tue, 19 Sep 2006 00:32:27 +0000
Subject: [PATCH] Coverager: better error displaying

git-svn-id: svn://svn.lighttpd.net/xcache/trunk@185 c26eb9a1-5813-0410-bd6c-c2e55f420ca7
---
 coverager/coverager.css     | 1 +
 coverager/coverager.php     | 6 ++++--
 coverager/coverager.tpl.php | 5 ++++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/coverager/coverager.css b/coverager/coverager.css
index 458a69c..5137082 100644
--- a/coverager/coverager.css
+++ b/coverager/coverager.css
@@ -60,3 +60,4 @@ pre.code {
 }
 
 .footnote { text-align: right; font-size: 12px; }
+.error { color: red; }
diff --git a/coverager/coverager.php b/coverager/coverager.php
index f019efa..8d56a60 100644
--- a/coverager/coverager.php
+++ b/coverager/coverager.php
@@ -124,10 +124,12 @@ class XcacheCoverageViewer
 			}
 		}
 		else if (!$this->datadir) {
-			$action = 'require xcache.coveragedump_directory';
+			$action = 'error';
+			$error  = 'require `ini:xcache.coveragedump_directory` or `config:$datadir` to be set';
 		}
 		else {
-			$action = "no data";
+			$action = 'error';
+			$error  = "no data";
 		}
 
 		$xcache_version = defined('XCACHE_VERSION') ? XCACHE_VERSION : '';
diff --git a/coverager/coverager.tpl.php b/coverager/coverager.tpl.php
index 789884b..31c0e81 100644
--- a/coverager/coverager.tpl.php
+++ b/coverager/coverager.tpl.php
@@ -225,7 +225,10 @@ EOS;
 	}
 }
 else {
-	echo htmlspecialchars($action);
+	$error_html = htmlspecialchars($error);
+	echo <<<EOS
+	<span class="error">{$error_html}</span>
+EOS;
 }
 ?>