Stefan Bühler
07dd0bd0a5
add force_assert() to enforce assertions as simple assert()s are disabled by -DNDEBUG ( fixes #2546 )
...
From: Stefan Bühler <stbuehler@web.de>
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2948 152afb58-edef-0310-8abb-c4023f1b3aa9
9 years ago
Stefan Bühler
6f208cfde1
fix/silence bugs reported by ccc-analyzer (clang)
...
These should all be non critical:
* memory leaks on startup in error cases (which lead to
immediate shutdowns anyway)
* http_auth/ldap: passing uninitialized "ret" to ldap_err2string
* sizeof(T) not matching the target pointer in malloc/calloc calls;
those cases were either:
* T being the wrong pointer type - shouldn't matter as long as all
pointers have same size
* T being larger than the type needed
* mod_accesslog: direct use after free in cleanup (server shutdown);
could crash before "clean" shutdown
* some false positives (mod_compress, mod_expire)
* assert(srv->config_context->used > 0); - this is always the case,
as there is always a global config block
From: Stefan Bühler <stbuehler@web.de>
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2920 152afb58-edef-0310-8abb-c4023f1b3aa9
10 years ago
Stefan Bühler
559b198f86
[auth] put REMOTE_USER into cgi environment, making it accessible to lua via lighty.req_env ( fixes #2495 )
...
From: Stefan Bühler <stbuehler@web.de>
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2892 152afb58-edef-0310-8abb-c4023f1b3aa9
10 years ago
Stefan Bühler
05858f6cf2
[ssl] Fix $HTTP["scheme"] conditional, could be "http" for ssl connections if the ssl $SERVER["socket"] conditional was nested ( fixes #2501 )
...
con->conf.is_ssl got removed and replaced by:
* con->conf.ssl_enabled for the config var "ssl.engine" - it is only
used to determine which server-sockets should use ssl. (usually not
needed as it is mandatory and enough to set ssl.pemfile anyway)
* con->srv_socket->is_ssl to detect the actual ssl status of the
bound socket, which is the same as the ssl status of the connection
* con->uri.scheme for the actual $HTTP["scheme"] value, also used for
the CGI "HTTPS=ON" variable. This defaults to "https" if the
connection uses ssl, but can be changed for example by mod_extforward
if X-Forwarded-Proto: is set to either "http" or "https" (other values
are ignored right now)
Also removed the broken srv_socket->is_proxy_ssl as it was a connection
value in a server_socket struct...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2887 152afb58-edef-0310-8abb-c4023f1b3aa9
10 years ago
Cyril Brulebois
9c43331382
Use NULL instead of 0 where pointers are expected.
...
There are 6 remaining occurrences after this commit, in mod_compress,
due to zlib's Z_NULL being defined as 0 instead of NULL.
Signed-off-by: Cyril Brulebois <kibi@debian.org>
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2845 152afb58-edef-0310-8abb-c4023f1b3aa9
11 years ago
Cyril Brulebois
0c6a564543
Fix non-ANSI function declarations.
...
The proper way to declare a function taking no parameters isn't:
foo bar();
But this instead:
foo bar(void);
Signed-off-by: Cyril Brulebois <kibi@debian.org>
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2843 152afb58-edef-0310-8abb-c4023f1b3aa9
11 years ago
Stefan Bühler
5677f17442
[mod_*cgi,mod_accesslog] Fix splitting :port with ipv6 ( fixes #2333 , thx simoncpu)
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2834 152afb58-edef-0310-8abb-c4023f1b3aa9
11 years ago
Stefan Bühler
761bedd7fe
[libev/cgi] fix waitpid ECHILD errors in cgi with libev ( fixes #2324 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2816 152afb58-edef-0310-8abb-c4023f1b3aa9
12 years ago
Stefan Bühler
adc97e5ba3
[*cgi] Use physical base dir (alias, userdir) as DOCUMENT_ROOT in cgi environments ( fixes #2216 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2794 152afb58-edef-0310-8abb-c4023f1b3aa9
12 years ago
Stefan Bühler
33e30b486a
mod_cgi: make read buffer as big as incoming data block
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2778 152afb58-edef-0310-8abb-c4023f1b3aa9
12 years ago
Stefan Bühler
7e5b0fe9ab
Rename fdevent_event_add to _set to reflect what the function does. Fix some handlers.
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2765 152afb58-edef-0310-8abb-c4023f1b3aa9
13 years ago
Stefan Bühler
38f2d1ddd7
cleanup fdevent code, removed linux-rtsig handler, replaced some fprintf calls
...
* use log functions
* convert flags
* fix handler callback prototype
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2752 152afb58-edef-0310-8abb-c4023f1b3aa9
13 years ago
Stefan Bühler
73e0bb2715
mod_cgi: fix race condition leaving response not forwarded to client ( fixes #2217 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2737 152afb58-edef-0310-8abb-c4023f1b3aa9
13 years ago
Stefan Bühler
85b1f6afd3
Fix fd leaks in mod_cgi (fds not closed on pipe/fork failures, found by Rodrigo, fixes #2158 , #2159 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2706 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
e21a83934e
Fix mod_cgi cgi.execute-x-only option in global block
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2702 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
22e8b456a9
Fix header inclusion order, always include "config.h" before any system header
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2624 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
4df22f2a32
Fix issues found with clang analyzer
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2594 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
3c11705903
Add "cgi.execute-x-only" to mod_cgi, requires +x for cgi scripts ( fixes #2013 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2558 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
fbdb305f8a
Add server.breakagelog, a "special" stderr ( fixes #1863 )
...
* The breakage-log simply replaces stderr (the old stderr is moved away if needed for errorlog),
and stderr isn't closed after forking.
It defaults to stderr if started with -n (no daemonize), otherwise it defaults to /dev/null.
It is _not_ reopened in log_error_cycle, as there may be many long running childs which have it
still open anyway. Use a pipe-logger with cycle-support if you need it.
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2550 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
a78acf99a1
Fix mod_cgi environment keys mangling ( fixes #1969 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2497 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
ecfdc60945
Fix SERVER_NAME port stripping ( fixes #1968 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2492 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
2e823e8d14
Use server.tag for SERVER_SOFTWARE if configured ( fixes #357 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2471 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
638ee6cad9
Add revision number to package version for svn/git checkouts
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2467 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
1527160c69
Add support for pipe logging for server.errorlog ( fixes #296 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2466 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
ff5c18bee8
Check for regular file in mod_cgi, so we don't try to start directories
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2439 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
def70d86e9
Remove the optional port info from SERVER_NAME (thx Mr_Bond)
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2431 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
63f785a2f8
Added some extra warning options in cmake and fix the resulting warnings (unused/static functions)
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2414 152afb58-edef-0310-8abb-c4023f1b3aa9
14 years ago
Stefan Bühler
90bfe20bf5
Fix mod_cgi segfault when bound to unix domain socket ( #653 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2316 152afb58-edef-0310-8abb-c4023f1b3aa9
15 years ago
Stefan Bühler
b8835ab9a8
Allow digits in [s]cgi env vars ( #1712 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2274 152afb58-edef-0310-8abb-c4023f1b3aa9
15 years ago
Stefan Bühler
ad12e4c5b2
Insert many con->mode checks; they should prevent two modules to handle the same request if they shouldn't ( #631 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2271 152afb58-edef-0310-8abb-c4023f1b3aa9
15 years ago
Stefan Bühler
52861d77df
Replace buffer_{append,copy}_string with the _len variant where possible ( #1732 , thx crypt)
...
Replace BUFFER_{APPEND,COPY}_STRING_CONST with _len(b, CONST_STRL_LEN(x))
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2250 152afb58-edef-0310-8abb-c4023f1b3aa9
15 years ago
Stefan Bühler
93e7167f84
Implement a clean way to open /dev/null and use it to close stdin/out/err in the needed places ( #624 )
...
- as stderr gets redirected to /dev/null before exec in childs, we cannot
write to the log afterwards, so disabled that log messages too.
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2163 152afb58-edef-0310-8abb-c4023f1b3aa9
15 years ago
Stefan Bühler
8dd78e06c7
Handle EINTR in mod_cgi during write() ( #1640 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2153 152afb58-edef-0310-8abb-c4023f1b3aa9
15 years ago
Stefan Bühler
c065f36bc1
r2136@chromobil: stefan | 2008-02-28 22:18:14 +0100
...
Fix sending source of cgi script instead of 500 error if fork fails
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2107 152afb58-edef-0310-8abb-c4023f1b3aa9
15 years ago
Jan Kneschke
830bb59d86
don't report the "cgi died ?" in case we killed the dangling CGI process
...
with SIGTERM
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2065 152afb58-edef-0310-8abb-c4023f1b3aa9
16 years ago
Jan Kneschke
51826fc05c
renamed ltostr() to LI_ltostr() to fix compile on HP/UX ( fixes #465 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@1951 152afb58-edef-0310-8abb-c4023f1b3aa9
16 years ago
Jan Kneschke
41e836b410
fixed extracting status code from NPH scripts ( fixes #1125 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@1948 152afb58-edef-0310-8abb-c4023f1b3aa9
16 years ago
Jan Kneschke
dc4879473f
removed debug msg
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@1937 152afb58-edef-0310-8abb-c4023f1b3aa9
16 years ago
Jan Kneschke
f0333c8c0d
fixed crash on mixed \r\n and \n sequences
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@1925 152afb58-edef-0310-8abb-c4023f1b3aa9
16 years ago
Marcus Rückert
ba424e2293
- fix the previous commit
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@1687 152afb58-edef-0310-8abb-c4023f1b3aa9
17 years ago
Marcus Rückert
b3f333d32e
- add HTTPS=on to the environment of cgi scripts ( #861 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@1684 152afb58-edef-0310-8abb-c4023f1b3aa9
17 years ago
Marcus Rückert
8cd1471cb3
- white space cleanup part 2 this time 1.4 ;)
...
i hope it helps with merging stuff back to 1.5
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@1371 152afb58-edef-0310-8abb-c4023f1b3aa9
17 years ago
Jan Kneschke
1982fda295
- close unused pipe-fds as soon as possible to generate a SIGPIPE if the remote end dies.
...
- only send REQUEST_URI and QUERY_STRING if they are set
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@1006 152afb58-edef-0310-8abb-c4023f1b3aa9
18 years ago
Jan Kneschke
ba50f7fbfc
don't terminate the request, just ignore it
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@999 152afb58-edef-0310-8abb-c4023f1b3aa9
18 years ago
Jan Kneschke
562f5c8e1f
mod_scgi was illegally returning HANDLER_ERROR which cause a running cgi-request to be terminated.
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@984 152afb58-edef-0310-8abb-c4023f1b3aa9
18 years ago
Jan Kneschke
433f1883ac
improved performance of env-creation and added DOCUMENT_ROOT to the env
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@973 152afb58-edef-0310-8abb-c4023f1b3aa9
18 years ago
Jan Kneschke
6e193e4040
make AIX happy and include fcntl.h instead of sys/fcntl.h ( fixes #417 )
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@892 152afb58-edef-0310-8abb-c4023f1b3aa9
18 years ago
Jan Kneschke
d35482ee9a
fixed typo (and next time I should at least compile before commiting)
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@886 152afb58-edef-0310-8abb-c4023f1b3aa9
18 years ago
Jan Kneschke
4de36723c0
cleanup the connection-internals at the end of the of the response and not at the end of the connection
...
- fixed 100% loops and error-log messages for mod_cgi ("sandy" <sjen@cs.stanford.edu>)
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@884 152afb58-edef-0310-8abb-c4023f1b3aa9
18 years ago
Jan Kneschke
2cc4f96765
fixed streaming cgi output (like cgi-irc)
...
git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@870 152afb58-edef-0310-8abb-c4023f1b3aa9
18 years ago