diff --git a/NEWS b/NEWS index 7c29eb20..a9916b7e 100644 --- a/NEWS +++ b/NEWS @@ -9,6 +9,7 @@ NEWS * [mod_rrdtool] fix invalid read (string not null terminated) * [mod_dirlisting] fix memory leak if pcre fails * [mod_fastcgi,mod_scgi] fix resource leaks on spawning backends + * [mod_magnet] fix memory leak - 1.4.34 * [mod_auth] explicitly link ssl for SHA1 (fixes #2517) diff --git a/src/mod_magnet.c b/src/mod_magnet.c index d3069f6a..643b02aa 100644 --- a/src/mod_magnet.c +++ b/src/mod_magnet.c @@ -786,10 +786,12 @@ static int magnet_attach_content(server *srv, connection *con, plugin_data *p, l } if (off < 0) { + buffer_free(fn); return luaL_error(L, "offset for '%s' is negative", fn->ptr); } if (len < off) { + buffer_free(fn); return luaL_error(L, "offset > length for '%s'", fn->ptr); }