From 5e39c81ff2b0be9e28750f9a3b3f3bca59e15a9b Mon Sep 17 00:00:00 2001 From: Glenn Strauss Date: Tue, 4 May 2021 13:12:16 -0400 Subject: [PATCH] [core] li_base64_decode mark cold code path --- src/base64.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/base64.c b/src/base64.c index d79a9da2..bbc6f85f 100644 --- a/src/base64.c +++ b/src/base64.c @@ -56,21 +56,19 @@ static size_t li_base64_decode(unsigned char * const result, const size_t out_le /* run through the whole string, converting as we go */ for (i = 0; i < in_length; i++) { - unsigned char c = (unsigned char) in[i]; - int ch; - - if (c == '\0') break; - if (c >= 128) return 0; /* only 7-bit characters allowed */ - - ch = base64_reverse_table[c]; - if (-3 == ch) { - /* pad character; can only come after 2 base64 digits in a group */ - if (group < 2) return 0; - break; - } else if (-2 == ch) { - continue; /* skip character */ - } else if (ch < 0) { - return 0; /* invalid character, abort */ + const int c = ((unsigned char *)in)[i]; + const int ch = (c < 128) ? base64_reverse_table[c] : -1; + if (__builtin_expect( (ch < 0), 0)) { + if (-3 == ch) { + /* pad character; can only come after 2 base64 digits in a group */ + if (group < 2) return 0; + break; + } else if (-2 == ch) { + continue; /* skip character */ + } else { + if (c == '\0') break; + return 0; /* invalid character, abort */ + } } switch(group) {