mod_scgi was illegally returning HANDLER_ERROR which cause a running cgi-request to be terminated.

git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-merge-1.4.x@984 152afb58-edef-0310-8abb-c4023f1b3aa9

src/mod_cgi.c

@@ -530,7 +530,7 @@ static handler_t cgi_connection_close(server *srv, handler_ctx *hctx) {
 			 * -> we get here with waitpid == ECHILD
 			 * 
 			 */
-			if (errno == ECHILD) return HANDLER_FINISHED;
+			if (errno == ECHILD) return HANDLER_GO_ON;
 			
 			log_error_write(srv, __FILE__, __LINE__, "ss", "waitpid failed: ", strerror(errno));
 			return HANDLER_ERROR;
@@ -548,11 +548,11 @@ static handler_t cgi_connection_close(server *srv, handler_ctx *hctx) {
 #endif
 				pid = 0;
 				
-				return HANDLER_FINISHED;
+				return HANDLER_GO_ON;
 			} else {
 				log_error_write(srv, __FILE__, __LINE__, "sd", "cgi died, pid:", pid);
 				pid = 0;
-				return HANDLER_FINISHED;
+				return HANDLER_GO_ON;
 			}
 		}
 		
@@ -563,7 +563,7 @@ static handler_t cgi_connection_close(server *srv, handler_ctx *hctx) {
 		cgi_pid_add(srv, p, pid);
 	}
 #endif	
-	return HANDLER_FINISHED;
+	return HANDLER_GO_ON;
 }
 
 static handler_t cgi_connection_close_callback(server *srv, connection *con, void *p_d) {

src/mod_scgi.c

@@ -2679,9 +2679,7 @@ static handler_t scgi_check_extension(server *srv, connection *con, void *p_d, i
 	
 	fn = uri_path_handler ? con->uri.path : con->physical.path;
 
-	if (fn->used == 0) {
-		return HANDLER_ERROR;
-	}
+	if (buffer_is_empty(fn)) return HANDLER_GO_ON;
 
 	s_len = fn->used - 1;