diff --git a/NEWS b/NEWS index 83e41094..f5a674ed 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,7 @@ NEWS * Add server.breakagelog, a "special" stderr (fixes #1863) * Fix config evaluation for debug.log-timeouts option (#1529) * Add "cgi.execute-x-only" to mod_cgi, requires +x for cgi scripts (fixes #2013) + * Fix FD_SETSIZE comparision warnings - 1.4.23 - 2009-06-19 * Added some extra warning options in cmake and fix the resulting warnings (unused/static functions) diff --git a/src/fdevent_select.c b/src/fdevent_select.c index 4dcb7549..079e794e 100644 --- a/src/fdevent_select.c +++ b/src/fdevent_select.c @@ -38,7 +38,7 @@ static int fdevent_select_event_add(fdevents *ev, int fde_ndx, int fd, int event UNUSED(fde_ndx); /* we should be protected by max-fds, but you never know */ - assert(fd < FD_SETSIZE); + assert(fd < ((int)FD_SETSIZE)); if (events & FDEVENT_IN) { FD_SET(fd, &(ev->select_set_read)); diff --git a/src/server.c b/src/server.c index 5a38dcc6..ceb4c10a 100644 --- a/src/server.c +++ b/src/server.c @@ -719,7 +719,7 @@ int main (int argc, char **argv) { } if (srv->event_handler == FDEVENT_HANDLER_SELECT) { - srv->max_fds = rlim.rlim_cur < FD_SETSIZE - 200 ? rlim.rlim_cur : FD_SETSIZE - 200; + srv->max_fds = rlim.rlim_cur < ((int)FD_SETSIZE) - 200 ? rlim.rlim_cur : FD_SETSIZE - 200; } else { srv->max_fds = rlim.rlim_cur; } @@ -732,7 +732,7 @@ int main (int argc, char **argv) { #endif if (srv->event_handler == FDEVENT_HANDLER_SELECT) { /* don't raise the limit above FD_SET_SIZE */ - if (srv->max_fds > FD_SETSIZE - 200) { + if (srv->max_fds > ((int)FD_SETSIZE) - 200) { log_error_write(srv, __FILE__, __LINE__, "sd", "can't raise max filedescriptors above", FD_SETSIZE - 200, "if event-handler is 'select'. Use 'poll' or something else or reduce server.max-fds."); @@ -845,7 +845,7 @@ int main (int argc, char **argv) { } if (srv->event_handler == FDEVENT_HANDLER_SELECT) { - srv->max_fds = rlim.rlim_cur < FD_SETSIZE - 200 ? rlim.rlim_cur : FD_SETSIZE - 200; + srv->max_fds = rlim.rlim_cur < ((int)FD_SETSIZE) - 200 ? rlim.rlim_cur : FD_SETSIZE - 200; } else { srv->max_fds = rlim.rlim_cur; } @@ -859,7 +859,7 @@ int main (int argc, char **argv) { #endif if (srv->event_handler == FDEVENT_HANDLER_SELECT) { /* don't raise the limit above FD_SET_SIZE */ - if (srv->max_fds > FD_SETSIZE - 200) { + if (srv->max_fds > ((int)FD_SETSIZE) - 200) { log_error_write(srv, __FILE__, __LINE__, "sd", "can't raise max filedescriptors above", FD_SETSIZE - 200, "if event-handler is 'select'. Use 'poll' or something else or reduce server.max-fds.");